bpo-16866 Fix make libainstall.#25980
Merged
Merged
Conversation
Contributor
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
Contributor
|
Sorry @orsenthil, I had trouble checking out the |
|
GH-25981 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 8, 2021
Initial patch by Benno Leslie. (cherry picked from commit 80d250d) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
orsenthil
added
needs backport to 3.10
Contributor
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-25982 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
May 8, 2021
Initial patch by Benno Leslie. (cherry picked from commit 80d250d) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
miss-islington
added a commit
that referenced
this pull request
May 8, 2021
Initial patch by Benno Leslie. (cherry picked from commit 80d250d) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
target is broken.
Looks like the BINDIR dependency was added here - 49fd7fa#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767cR833 but we didn't add the directory creation dependency then.
A simple fix of add BINDIR as dependency seems OK to me. At least it wont break the libainstall standalone target.
With the fix,
make libainstallworks fine.https://bugs.python.org/issue16866